[Tickets #7272] Re: Date_Holidays split up breaks translation support for non-christian drivers

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7272
------------------------------------------------------------------------------
  Ticket             | 7272
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | Date_Holidays split up breaks translation support for
                     | non-christian drivers
  Queue              | Kronolith
  Version            | 2.2
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
-Milestone          |
+Milestone          | 2.3.1
  Patch              |
-Owners             | Horde Developers, Jan Schneider
+Owners             | Jan Schneider
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2009-01-24 12:53) wrote:

> In kronolith/lib/Driver/holidays.php, on line 83 (version 2.3), the
> line that reads
>  $holidays = $dh->getHolidayForDate($date->timestamp(), $GLOBALS['l
> anguage'], true);
>
> must be changed to
>  $holidays = $dh->getHolidayForDate($date->format('Y-m-d'), $GLOBALS['
> language'], true);

This is not true, Date_Holidays_Driver is already doing exactly that  
if you pass it a timestamp.

The original issue has been fixed in Date_Holiday though.