[Tickets #7934] Re: smb driver's _command needs to be charset aware

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7934
------------------------------------------------------------------------------
  Ticket             | 7934
  Updated By         | leena.heino at uta.fi
  Summary            | smb driver's _command needs to be charset aware
  Queue              | Horde Framework Packages
  Version            | HEAD
  Type               | Enhancement
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


leena.heino at uta.fi (2009-02-06 18:41) wrote:

>>>> That doesn't make any sense to me because
>>>> - we already set LC_ALL in horde
>>
>> That may be, but that environment is not passed to smbclient command
>> in _command().
>
> This might be a problem with your system, if LC_ALL doesn't set
> LC_CTYPE. Or are you saying that LC_ALL isn't set either?
>

 From my point of view in the testing, it seems that the LC_ALL is not  
set when the smbclient command is evoked in the smb backend driver.

>>>> - this only works with horde anyway, but this is a pear package.
>>>> please revert.
>>>
>>> Done.  Although the 1st point seems irrelevant to me: if this is
>>> truly a PEAR package, then we necessarily have to set LC_* inside the
>>> driver because there are no guarantees that it will have been set
>>> elsewhere since Horde is not a pre-requisite.
>>
>> My testing showed that smbdriver might work correctly without this
>> patch, but only if host's default environment and the current locale
>> in gollem use the same charset.
>
> But the assumption that the files in the Samba backend have the same
> locale like the current Horde frontend is completely wrong. If at
> all, then we need to specify a charset per backend, and convert
> to/from that.

Actually smbclient command does the character conversion for you when  
you give the character set you want in the LC_CTYPE.