[Tickets #6861] Re: yaml dumper should quote values with comments

bugs at horde.org bugs at horde.org
Sat May 2 02:37:58 UTC 2009


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/6861
------------------------------------------------------------------------------
  Ticket             | 6861
  Updated By         | apinstein at mac.com
  Summary            | yaml dumper should quote values with comments
  Queue              | Horde Framework Packages
  Version            | FRAMEWORK_3
  Type               | Bug
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Mike Naberezny, Chuck Hagenbuch
------------------------------------------------------------------------------


apinstein at mac.com (2009-05-01 22:37) wrote:

I just figured out why the tests were failing for me. I have syck  
installed, and just realized that Horde calls syck, which outputs  
different YAML than Horde/Yaml does. When I disabled syck temporarily  
all of the tests pass.

FWIW, you might consider making your tests do round-trip tests like so:

$this->assertEquals($inputPhpStruct, load(dump($inputPhpStruct)))

Also you might consider an option to "disable" syck use and use this  
option for the tests to ensure that testing is actually testing the  
Horde/Yaml code!

Thanks for accepting the patch.

Alan






More information about the bugs mailing list