[Tickets #8296] Re: Highlight background of PGP messages

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8296
------------------------------------------------------------------------------
  Ticket             | 8296
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Highlight background of PGP messages
  Queue              | IMP
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Horde Developers
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2009-05-29 01:51) wrote:

> Yes, I already got that far, but the problem is that the mime parts
> responsible for verifying the signature (and providing the bg color)
> and for rendering the actual message text (and showing the bg color)
> don't "know" of each other. Thing especially get worse if re-building
> a "virtual" message from embedded mime parts if the message is inline
> armored.

This should be easy enough to fix/hack around - the verifying code  
could easily store the information in the parent multipart/signed  
Viewer and/or part so that all other children parts can access this  
information.

> Btw, in this case, the part information being displayed in the
> message view is incorrect because it reflects the virtual message,
> not the original one.

I assume you are talking about the "fake" parts created from the  
armored text.  That was a rough first implementation (my personal  
motiviation to play around with armored messages is limited because it  
was deprecated ages ago) but a necessary one since armored messages  
may contain multiple parts inside of them.  Display of the 'x-imp...'  
part is best hidden at some point in the future (the part is currently  
necessary because it is the only place that contains the full text of  
the message necessary to verify the signature).