[Tickets #8338] missing 'uid' in turba_browse

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8338
------------------------------------------------------------------------------
  Ticket             | 8338
  Created By         | rpolli at babel.it
  Summary            | missing 'uid' in turba_browse
  Queue              | Turba
  Version            | 2.3.1
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          | 2.3.1
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


rpolli at babel.it (2009-06-10 08:30) wrote:

missing 'uid' in turba_browse properties.
note: if contact->getValue issues a call instead of a simple attribute  
retrieval from an object, it could be optimized with a function like:
if  ! defined(item[guid]):
    item[guid] = item.getValue('_uid')

return item[guid]

Patch follows. The same in kronolith and maybe in all other modules...

@@ -580,6 +584,9 @@
              if (in_array('created', $properties)) {
                  $results[$key]['created'] =  
_turba_getActionTimestamp($contact->getValue('__uid'), 'add');
              }
+           if (in_array('uid', $properties)) { // rpolli .,+2
+               $results[$key]['uid'] = $contact->getValue('__uid');
+           }
          }

          return $results;