[Tickets #8413] Re: malformed img tag causes images to be shown regardless of html_image_replacement setting

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8413
------------------------------------------------------------------------------
  Ticket             | 8413
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | malformed img tag causes images to be shown regardless
                     | of html_image_replacement setting
  Queue              | IMP
  Version            | 4.3.4
  Type               | Bug
-State              | Unconfirmed
+State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
-Owners             |
+Owners             | Michael Slusarz
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2009-07-07 18:17) wrote:

That img tag had 2 src attributes, and had the info in the first  
attribute.  The regex was too greedy and was ignoring all text in the  
tag between '<img' and the final 'src=' text.  Solution was to make  
that part of the regex ungreedy.

An img tag with multiple src attributes that doesn't contain a correct  
source link in the first src attribute will not display the image at  
all, even after clicking on Display these images.  But absent a  
super-complex preg regex, this is acceptable (after all, the message  
is broken).

Running tidy fixed this issue without the need for the regexp change.