[Tickets #8267] Re: DIMP preview errors in folders other than Inbox

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8267
------------------------------------------------------------------------------
  Ticket             | 8267
  Updated By         | simon at abominable.org.uk
  Summary            | DIMP preview errors in folders other than Inbox
  Queue              | DIMP
  Version            | 1.1.2
  Type               | Bug
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


simon at abominable.org.uk (2009-07-20 19:32) wrote:

I encountered same issue in stable DIMP (1.1.2) with FF3.5, and found  
what I think is the cause (annoyingly I only found this ticket  
afterwards - otherwise I'd have just applied the fix from CVS!).

The message list ViewPort contains elements with DOM IDs of the form  
vp_row[UID][MAILBOX]. For subfolders these look like  
'vp_row1234Lists/Horde', i.e. invalid HTML ID (cannot contain  
forward-slash). This breaks Prototype in Selector.findElements, for  
browsers that implement Selectors API.

Replacing non-word characters (as is done elsewhere in DIMP) fixed it  
for me, i.e:

--- ViewPort-old.js	2009-07-20 23:16:35.000000000 +0100
+++ ViewPort.js	2009-07-20 22:48:50.000000000 +0100
@@ -1253,7 +1253,7 @@
              if (!Object.isUndefined(e)) {
                  // We can directly write the rownum to the original object
                  // since we will always rewrite when creating rows.
-                e.domid = 'vp_row' + u;
+                e.domid = 'vp_row' +  
u.replace(/_/g,'__').replace(/\W/g, '_');
                  e.rownum = this.uidlist.get(u);
                  e.vp_id = u;
                  return e;

I'd take a look at IMP 5 to see how this got fixed, but horde.org  
seems broken at the moment...