[Tickets #8577] vacation rule : maildrop/mailbot locks

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8577
------------------------------------------------------------------------------
  Ticket             | 8577
  Created By         | rsalmon at mbpgroup.com
  Summary            | vacation rule : maildrop/mailbot locks
  Queue              | Ingo
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 3. High
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


rsalmon at mbpgroup.com (2009-09-15 07:36) wrote:

mailbot uses a lock before opening sender's email database. the  
database file is defined with arg '-d '.
In file ingo/lib/Script/maildrop.php:523, database filename is defined  
as 'vacation'. Therefore mailbot uses file 'vacation.lock' as the file  
lock , which is the same file lock defined for maildrop (line 516).
so, if a user set start and end vacation dates, maildrop and mailbot  
will try to lock the same file which will never work.

here is a patch:

-            $this->_action[] = "  cc \"| mailbot -D " .  
$params['action-value']['days'] . " -c '" . NLS::getCharset() . "' -t  
\$HOME/vacation.msg -d \$HOME/vacation -A 'From: $from' -s '" .  
MIME::encode($params['action-value']['subject'], NLS::getCharset())  .  
"' /usr/sbin/sendmail -t \"";
+            $this->_action[] = "  cc \"| mailbot -D " .  
$params['action-value']['days'] . " -c '" . NLS::getCharset() . "' -t  
\$HOME/vacation.msg -d \$HOME/vacationbot -A 'From: $from' -s '" .  
MIME::encode($params['action-value']['subject'], NLS::getCharset())  .  
"' /usr/sbin/sendmail -t \"";