[Tickets #8612] Re: Download All Attachments (in .zip file) link generates corrupted zip files

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8612
------------------------------------------------------------------------------
  Ticket             | 8612
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Download All Attachments (in .zip file) link generates
                     | corrupted zip files
  Queue              | IMP
  Version            | 4.3.4
  Type               | Bug
  State              | Feedback
-Priority           | 2. Medium
+Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2009-09-30 04:46) wrote:

Then you will need to find where that extra line break is coming from.  
  It isn't coming from either IMP's view.php or the Horde_Compress::  
zip driver.

Horde_Compress::compress() sets the $contents variable to '' (the  
empty string).  On the first call to _addToZipFile(), the first data  
added to contents is $this->_fileHeader, which is "\x50\x4b\x03\x04".   
So that's not the issue.

view.php simply takes the output from compress and directly outputs  
it.  In the 1 line between the call to compress() and the echo call,  
there is no prepending of a linebreak.

you will need to trace on your system where the "\n" is coming from.