[Tickets #8677] Explicit :text in sieve body rule

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8677
------------------------------------------------------------------------------
  Ticket             | 8677
  Created By         | brennan at columbia.edu
  Summary            | Explicit :text in sieve body rule
  Queue              | Ingo
  Version            | 1.2
  Type               | Enhancement
  State              | New
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


brennan at columbia.edu (2009-11-05 10:22) wrote:

Should ingo/lib/Script/sieve.php put :text explicitly into body  
checks?  RFC 5173 says that body transform "can" be applied (odd  
word-- not may or should) and that :text is the default (or that is,  
it "can" be the default?).  Cyrus sieve does default to :text.  Still,  
adding :text would clarify to humans reading the script that only text  
parts will be searched.  One-line diff below.

Forget this if there are sieve implementations that don't do body  
transform at all that would break on being told :text.


--- 2125,2131 ----
       function toCode()
       {
           $code = 'body ' .
+           ':text ' .
               ':comparator "' . $this->_vars['comparator'] . '" ' .
               $this->_vars['match-type'] . '