[Tickets #8716] Re: Week view events spans are incorrect

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8716
------------------------------------------------------------------------------
  Ticket             | 8716
  Updated By         | arnaud.didry at univ-avignon.fr
  Summary            | Week view events spans are incorrect
  Queue              | Horde Groupware Webmail Edition
  Version            | 1.2.4
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


arnaud.didry at univ-avignon.fr (2009-11-19 12:59) wrote:

I think I finally found the origins of the bug.

First, $event->indent was miscalculated because $hspan doesn't count  
empties cells at the beginning of a day, which affected the  
calculation of the coverage graph.

Once this bug was corrected, I found that the span was miscalculated  
when collision occurs between two events : when the first half of an  
event "A" (width indent=0) is in collision with another event "B"  
(with indent=2); it was impossible to calculate the span of event "A"  
once event "B" is finished, affecting the value of hspan and the  
number of empties "td" appended at the end of a timeslot. To fix this,  
I stored the span of an event at its first computation.

The problem of colspan float values is still present, I temporary  
fixed it with "ceil()" but I think that another ticket needs to be  
opened.

It's not related to the bug, but I added a css class to empty cells  
between each day to be able to easily add color to them.

Everything seems to work now, I just need to do some more tests.

Sorry for my poor english, some comments in the patch may need to be  
rewritten.