[Tickets #8886] Notifications do not show in setup/config

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8886
------------------------------------------------------------------------------
  Ticket             | 8886
  Created By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Notifications do not show in setup/config
  Queue              | Horde Base
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Horde Developers, Michael Slusarz
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2010-02-26 11:36) wrote:

the $notification->push() call in horde/templates/admin/menu.inc is  
causing a js error:

document.observe is not a function
http://localhost/horde/admin/setup/config.php?app=horde
Line 25

It's due to the fact that prototype is loaded after this is output to  
the browser.  I tried tracing this, and I *think* it's an issue  
similar to one I had in Ansel where I was using output buffering to  
get some HTML output before common-header was sent.  I think that in   
admin/config.php when $form is generated by Util::bufferOutput(), this  
confuses the code that determines if we can send the javascript to the  
browser.  In Ansel, I fixed this by shuffling around where  
common-header was output in relation to the javascript being added  
etc... but I can't seem to figure this particular case out...  I'll  
keep trying, but someone with more familiarity with the notification  
code will probably be quicker at this.