[Tickets #8757] Re: Turba favourites driver does not provide removeUserData function

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/8757
------------------------------------------------------------------------------
  Ticket             | 8757
  Updated By         | Michael Rubinsky <mrubinsk at horde.org>
  Summary            | Turba favourites driver does not provide
                     | removeUserData function
  Queue              | IMP
  Version            | FRAMEWORK_3
  Type               | Enhancement
-State              | Accepted
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Michael Rubinsky <mrubinsk at horde.org> (2010-03-02 09:59) wrote:

> Yes, the problem is that favourites is implemented in IMP but  
> accessed through Turba. Turba calls removeUserData in  
> turba/lib/Driver/favourites.php, but since this wasn't implemented  
> an error was returned by the default implementation in  
> turba/lib/Driver.php. So I added removeUserData to  
> turba/lib/Driver/favourites.php but also had to create a new api  
> call to pass the request to IMP. Don't know if there is a cleaner  
> way to do this, perhaps by moving favourites functionality from IMP  
> into Turba.

I agree with Jan. Turba is only a consumer of the favorites data, IMP  
is responsible for it. You should change your patch to implement a  
removeUserData api inside of IMP itself.  If you are concerned about  
getting an error message from Turba, I guess we can override the  
removeUserData method in favorites.php to have it simply return true,  
or perhaps a more accurate error message.