[Tickets #9095] Re: Ldap preferences

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9095
------------------------------------------------------------------------------
  Ticket             | 9095
  Updated By         | leandro.damascena at gmail.com
  Summary            | Ldap preferences
  Queue              | IMP
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             | Ben Klang, Michael Slusarz
+New Attachment     | prefldap.diff
------------------------------------------------------------------------------


leandro.damascena at gmail.com (2010-06-21 09:42) wrote:

I've found the solution to this problem... When IMP uses database  
backend for preferences, IMP saves just some preferences (I think  
"editable preferences", locked = false) and uses prefs file to get  
others. However when IMP uses ldap backend for preferences, IMP saves  
all of them in LDAP and it creates a trouble with dimp_show_preview  
pref.

In "imp/templates/dimp/javascript_defs_dimp.php" line 70
'preview_pref' => $GLOBALS['prefs']->getValue('dimp_show_preview') ===  
true ? 'horiz' : $GLOBALS['prefs']->getValue('dimp_show_preview'),
This never will be true because LDAP returns a string type and not a  
boolean type.

I've made a patch, can you guys analyze and give a feedback if it is a  
better way to solve it?