[Tickets #9219] Re: display_tasklists is saved on every page access

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9219
------------------------------------------------------------------------------
  Ticket             | 9219
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | display_tasklists is saved on every page access
  Queue              | Nag
  Version            | Git master
  Type               | Enhancement
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2010-09-22 19:54) wrote:

> Seeing this all over the place:
>
> 2010-09-22T00:39:08-06:00 DEBUG: HORDE [nag] Horde_Prefs: Storing  
> preference value (display_tasklists) [pid 30516 on line 257 of  
> "/disk2/src/horde/framework/Prefs/lib/Horde/Prefs.php"]

Move it further down into the if-clause where the saving is actually  
triggered. :)

> As someone who never uses nag, I have no idea why this needs/should  
> be updated every page load.  Even if the value isn't changing, we  
> shouldn't be wasting time recreating at all.  At a minimum, this  
> really needs to be cached (see, e.g., caching IMP's folder tree  
> using session caching as a fallback if no Cache system is available).

It's almost a no-op, so I wouldn't really care about that. And you  
probably see this because of the Copy/Move to Tasklist feature.