[Tickets #7442] Re: Wrong logic for showing action bar

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/7442
------------------------------------------------------------------------------
  Ticket             | 7442
  Updated By         | Matt Selsky <selsky at columbia.edu>
  Summary            | Wrong logic for showing action bar
  Queue              | IMP
-Version            | HEAD
+Version            | Git master
  Type               | Bug
-State              | Resolved
+State              | Assigned
  Priority           | 1. Low
  Milestone          |
-Patch              |
+Patch              | 1
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


Matt Selsky <selsky at columbia.edu> (2011-01-10 20:04) wrote:

The new algorithm doesn't seem correct.  If $_prefs['max_msgs'] is set  
to the default of 20, then $pageOb->end - $pageOb->begin will be 19  
most of the time (for mailboxes with >= 20 messages.  So ($pageOb->end  
- $pageOb->begin) >= 20 will be false most of the time and then bottom  
navbar won't be shown.

I think we instead want to compare the total message count in the  
mailbox to the max_msgs, and show the 2nd navbar if msgcount > max_msgs.

See attached patch.