[Tickets #9369] Re: Use ckeditor preferences on signatures too

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9369
------------------------------------------------------------------------------
  Ticket             | 9369
  Updated By         | rui.carneiro at portugalmail.net
  Summary            | Use ckeditor preferences on signatures too
  Queue              | IMP
  Version            | Git master
  Type               | Enhancement
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Slusarz
+New Attachment     | Screenshot.png
------------------------------------------------------------------------------


rui.carneiro at portugalmail.net (2011-01-18 05:20) wrote:

> What about this isn't working?  It works fine here.
Pulled your code and replaced my prefs.php with the defaults  
(prefs.php.dists) and is not working. In order to avoid any  
communication problem here I just uploaded a screenshot of the problem  
:)

> We should NEVER be manually entering CKEDITOR.replace() calls in .js  
> files - this is done by IMP_Ui_Editor::..
But this is the compose-dimp.js behavior:  
https://github.com/horde/horde/blob/master/imp/js/compose-dimp.js#L438

> Sure enough, it appears in the page output:
>
> <script type="text/javascript" src="/horde/imp/js/signaturehtml.js"></script>
> <script type="text/javascript">//<![CDATA[
> Event.observe(window, "load", function()  
> {CKEDITOR.replace("signature_html",{"scayt_autoStartup":false});});window.IMP =  
> [...]
Thats the problem. You are creating a CKEditor where the only config  
you have is {"scayt_autoStartup":false}. All other configurations  
(toolbar buttons, font-size, font-family, etc) are being ignored.

There is two aways to fix this:
- As compose-dimp.js, initialize IMP_Ui_Editor without an ID and do  
CKEditor.replace on signaturehtml.js.
- Fix IMP_Ui_Editor::init and use  
"$injector->getInstance('Horde_Editor')->initialize" to send the  
correct config to all Horde_Editor instances.