[Tickets #9369] Re: Use ckeditor preferences on signatures too

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9369
------------------------------------------------------------------------------
  Ticket             | 9369
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Use ckeditor preferences on signatures too
  Queue              | IMP
  Version            | Git master
  Type               | Enhancement
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2011-01-18 13:47) wrote:

>> We should NEVER be manually entering CKEDITOR.replace() calls in .js
>> files - this is done by IMP_Ui_Editor::..
> But this is the compose-dimp.js behavior:  
> https://github.com/horde/horde/blob/master/imp/js/compose-dimp.js#L438

This is a special case - it is needed because the HTML editor is being  
toggled within the page.  All other uses of HTML editor should be  
initialized automatically by calling Horde_Editor_Ckeditor.

>> Sure enough, it appears in the page output:
>>
>> <script type="text/javascript"  
>> src="/horde/imp/js/signaturehtml.js"></script>
>> <script type="text/javascript">//<![CDATA[
>> Event.observe(window, "load", function()
>> {CKEDITOR.replace("signature_html",{"scayt_autoStartup":false});});window.IMP  
>> =
>> [...]
> Thats the problem. You are creating a CKEditor where the only config  
> you have is {"scayt_autoStartup":false}. All other configurations  
> (toolbar buttons, font-size, font-family, etc) are being ignored.

I have spotted the issue - we should be telling ckeditor to use our  
configuration array which is stored in the page in a javascript  
variable.  Fixed.