[Tickets #9692] Vfolder prefs not correctly updated

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9692
------------------------------------------------------------------------------
  Ticket             | 9692
  Created By         | Jan Schneider <jan at horde.org>
  Summary            | Vfolder prefs not correctly updated
  Queue              | IMP
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 2. Medium
  Milestone          | 5.0
  Patch              |
  Owners             | Michael Slusarz
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2011-03-21 22:26) wrote:

I see two issues with upgrading of vfolder preferences:

1) The initial_page pref needs to updated, if it contains **search_......
Sidenote: is there any reason why the notification message about  
mailbox not found is displayed 3 times in the interface and 19 times  
in the log?

2) The vfolder pref is not correctly converted.
To test this, I created a fresh vfolder preference in IMP 4 and  
migrated that to IMP 5. The original preference value was:

a:1:{s:22:"45lr2nhothesccksok8kco";a:5:{s:5:"query";s:378:"O:21:"IMP_IMAP_Search_Query":8:{s:4:"_and";a:1:{i:0;a:1:{i:0;O:21:"IMP_IMAP_Search_Query":8:{s:4:"_and";a:0:{}s:15:"_extendedSearch";a:0:{}s:6:"_flags";a:0:{}s:4:"_not";N;s:3:"_or";a:0:{}s:6:"_query";s:12:"BODY  
"horde"";s:5:"_size";N;s:7:"_sizeop";N;}}}s:15:"_extendedSearch";a:0:{}s:6:"_flags";a:0:{}s:4:"_not";b:0;s:3:"_or";a:0:{}s:6:"_query";N;s:5:"_size";N;s:7:"_sizeop";N;}";s:7:"folders";a:5:{i:0;s:27:"INBOX.Mailinglisten.Bugtraq";i:1;s:25:"INBOX.Mailinglisten.Cyrus";i:2;s:25:"INBOX.Mailinglisten.Kolab";i:3;s:28:"INBOX.Mailinglisten.pear-dev";i:4;s:27:"INBOX.Mailinglisten.php-dev";}s:6:"uiinfo";a:10:{s:5:"field";a:4:{i:0;s:4:"from";i:1;s:2:"to";i:2;s:7:"subject";i:3;s:4:"body";}s:9:"field_end";i:4;s:5:"match";s:3:"and";s:4:"text";a:4:{i:0;s:0:"";i:1;s:0:"";i:2;s:0:"";i:3;s:5:"horde";}s:8:"text_not";N;s:4:"date";N;s:7:"folders";a:5:{i:0;s:27:"INBOX.Mailinglisten.Bugtraq";i:1;s:25:"INBOX.Mailinglisten.Cyrus";i:2;s:25:"INBOX.Mailinglisten.Kolab";i:3;s:28:"INBOX.Mailinglisten.pear-dev";i:4;s:27:"INBOX.Mailinglisten.php-dev";}s:12:"save_vfolder";s:2:"on";s:13:"vfolder_label";s:5:"Horde";s:4:"mbox";N;}s:5:"label";s:5:"Horde";s:7:"vfolder";b:1;}}

The converted is:

a:2:{i:0;C:25:"IMP_Search_Vfolder_Vinbox":30:{a:2:{s:1:"e";i:1;s:1:"v";i:1;}}i:1;C:18:"IMP_Search_Vfolder":378:{a:6:{s:1:"c";a:1:{i:0;C:23:"IMP_Search_Element_Text":29:{[1,{"b":1,"n":0,"t":"horde"}]}}s:1:"e";i:1;s:1:"i";s:23:"xEDdYxPcj3hNh86y1_NxbqA";s:1:"l";s:5:"Horde";s:1:"m";a:5:{i:0;s:27:"INBOX.Mailinglisten.Bugtraq";i:1;s:25:"INBOX.Mailinglisten.Cyrus";i:2;s:25:"INBOX.Mailinglisten.Kolab";i:3;s:28:"INBOX.Mailinglisten.pear-dev";i:4;s:27:"INBOX.Mailinglisten.php-dev";}s:1:"v";i:1;}}}

The problem with the latter is that it result in those vfolder labels and ids:

impsearch\0vinbox
impsearch\0xEDdYxPcj3hNh86y1_NxbqA

\0 is the nul character.