[Tickets #9845] Error displayed and logged whenever a message is deleted or restored

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9845
------------------------------------------------------------------------------
  Ticket             | 9845
  Created By         | jcblanco at fi.upm.es
  Summary            | Error displayed and logged whenever a message is
                     | deleted or restored
  Queue              | IMP
  Version            | 5.0
  Type               | Bug
  State              | Unconfirmed
  Priority           | 3. High
  Milestone          |
  Patch              | 1
  Owners             |
+New Attachment     | Horde_Imap_Client_Socket.php.patch.txt
------------------------------------------------------------------------------


jcblanco at fi.upm.es (2011-04-08 14:26) wrote:

in IMP traditional and dynamic Modes, whenever a message is deleted or  
restore we see an error message in the web page and also is logged,  
the error los is like:
  [Thu Apr 07 22:38:38 2011] [error] [client XXX.XXX.XXX.XXX] PHP  
Fatal error:  Call to a member function get() on a non-object in  
/usr/share/php5/PEAR/Horde/Imap/Client/Socket.php on line 2931,  
referer: http://XXX.fi.upm.es/horde/imp/

I've found that in version RC2 the code in the line 2931 was  
conditioned by a previous if in line 2921 of the RC version that  
checks for "condstore", in the FINAL version this check was removed.

If we apply the attached patch the error goes away but I don't know if  
this patch my cause some other error or missing code