[Tickets #9972] Link attachment couldn't be downloaded

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9972
------------------------------------------------------------------------------
  Ticket             | 9972
  Created By         | alberto at pesadilla.org
  Summary            | Link attachment couldn't be downloaded
  Queue              | IMP
  Version            | 5.0.1
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


alberto at pesadilla.org (2011-04-25 15:18) wrote:

Hello,

There is a problem with H4 and linked attachment.

This is not fixed en GIT version:
http://git.horde.org/co.php/imp/attachment.php?rt=horde-git&ws=1&r=8cc572d2fc648758a682d4a19742c50bcb36e62e

The link sent is http://address/imp/attachment.php?u=mail&t=timestamp&f=file

(i can confirm it with imp/lib/Compose.php file:  
http://git.horde.org/co.php/imp/lib/Compose.php?rt=horde-git&ws=1&r=22d8cbacb6182e2c36745e794696340337e2d93f lines  
2449->2463)

and the expected is user_name=mail&time_stamp=timestamp&filename=file




Solution could be:

imp/attachment.php (add lines between line 30 and line 31)
$vars->mail_user = $vars->u;
$vars->time_stamp = $vars->t;
$vars->file_name = $vars->f;

also there is a bug in line 31:
if (!$vars->mail_user || !$vars->$time_stamp || !$vars->file_name) {

$vars->time_stamp instead of $vars->$time_stamp




Furthermore, there is a problem sending a mail when attachment is downloaded

Solution could be:

imp/attachment.php
Change line 107: $msg->send($mail_address, $msg_headers);
with line: $msg->send($mail_address, $msg_headers,  
$GLOBALS['injector']->getInstance('IMP_Mail'));