[Tickets #9986] Database migration triggered on non-database setup

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9986
------------------------------------------------------------------------------
  Ticket             | 9986
  Created By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | Database migration triggered on non-database setup
  Queue              | Horde Base
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2011-04-26 13:34) wrote:

Hello,

I've updated my Kolab devel box to Horde4. The box is running without
a database server. I selected SQL type "none" in the horde prefs.

conf.php contained a "$conf['sql']['phptype'] = 'false' line IIRC.

Later on the LoginTasks for the admin try to trigger a DB upgrade
because of this code in horde/lib/LoginTasks/Task/AdminCheck.php:

         if (!empty($GLOBALS['conf']['sql'])) {
             /* Check for outdated DB schemas. */
             $migration = new Horde_Core_Db_Migration();
             foreach ($migration->apps as $app) {
                 $migrator = $migration->getMigrator($app);
                 if ($migrator->getTargetVersion() >  
$migrator->getCurrentVersion()) {
                     $GLOBALS['notification']->push(_("At least one  
database schema is outdated."), 'horde.warning');
                     Horde::url('admin/config', true, array('app' => 'horde'))
                         ->redirect();
                 }
             }

Should the [none] SQL database type completely remove
the $conf['sql'] key or does the code above need to handle the "false" case?

Cheers,
Thomas