[Tickets #10017] Re: applications are incorrectly "polled" even if they are not installed

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10017
------------------------------------------------------------------------------
  Ticket             | 10017
  Updated By         | vilius at lnk.lt
  Summary            | applications are incorrectly "polled" even if they are
                     | not installed
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Not A Bug
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


vilius at lnk.lt (2011-05-08 09:16) wrote:

>> Correct me if I'm wrong but this code always marks 'heading' and
>> 'sidebar' applications as active, no?
>>
>> } elseif ($app['status'] == 'heading' ||
>>              $app['status'] == 'sidebar') {
>>            continue;
>> }
>
> Yes - that is correct.
>
> But again, this should not matter.  Because in the sidebar  
> generation code, this happens:
>
>             case 'sidebar':
>                 try {
>                     $registry->callAppMethod($params['app'],  
> 'sidebarCreate', array('args' => array($this->_tree,  
> empty($params['menu_parent']) ? null : $params['menu_parent'],  
> isset($params['sidebar_params']) ? $params['sidebar_params'] :  
> array())));
>                 } catch (Horde_Exception $e) {
>                     if ($e->getCode() != Horde_Registry::NOT_ACTIVE) {
>                         Horde::logMessage($e, 'ERR');
>                     }
>                 }
>
> callAppMethod() should immediately fail because the application  
> ($params['app']) is not active.

It's not failling here. I've determined that entry point for the error  
is hasPermission check some lines sooner. Also I've modified  
callAppMethod to log the method which is called and got  
"authAuthenticateCallback" in all five logged cases. Further debugging  
is really over my head here.

> So once again, the question remains: why is this Exception returning  
> something other than Horde_Registry::NOT_ACTIVE for you?  Because  
> this is what is broken, not anything dealing with marking 'sidebar'  
> registry blocks active or inactive.

Again this doesn't happen on that particular Exception.