[Tickets #10072] Re: Memcache storage is duplicating the key prefix

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10072
------------------------------------------------------------------------------
  Ticket             | 10072
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Memcache storage is duplicating the key prefix
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
-State              | Unconfirmed
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
-Owners             |
+Owners             | Michael Slusarz
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2011-05-24 07:17) wrote:

> We are back to this issue, and discovered a problem on the existing  
> code (patch attached)

Slightly modified and committed (we shouldn't be changing the function  
signature because we are extending the method from the base class).   
Thanks for tracking this down.

> We agree that this is a conceptual problem, but it also doesn't make  
> sense having the Horde_Cache_Storage_Memcache + Horde_Memcache  
> duplicating the key prefix since one always calls the other.
>
> We could maybe pass an empty prefix when we build the  
> Horde_Cache_Storage_Memcache object based on the already prefixed  
> Horde_Memcache in Horde_Core_Factory_Cache. We are only looking to  
> the cache keys because we have a cache hit around 50% (which seems  
> very low). Is this the expected hit rate?

Memcache will have a mediocre hit rate because we do locking within  
memcache itself.  So there will be a lot of cache misses - every write  
will necessarily have a miss before.