[Tickets #9893] Re: Lightning<->RPC; Authentication doesn't work

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9893
------------------------------------------------------------------------------
  Ticket             | 9893
  Updated By         | sberthelot at emisfr.com
  Summary            | Lightning<->RPC; Authentication doesn't work
  Queue              | Kronolith
  Version            | 3.0
  Type               | Bug
  State              | Feedback
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


sberthelot at emisfr.com (2011-06-06 09:26) wrote:

I have had the same kinf of problem.

With a Kronlith 3.0.3 installed, my Lightning sync was working with  
Horde 3 and not with Horde 4.

I get a "HORDE [horde] Horde_Imap_Client requires a username and  
password. [pid 8146 on line 144 of  
"/var/www/horde/pear/php/Horde/Imap/Client/Base.php"]"

The HTTP authentication is never prompted.
Looking at the stack trace it goes to Horde_Rpc_Webdav->_check_auth()  
that checks for an internal function check_auth() that is always true  
(!) and then goes on Horde_Rpc_Webdav->check_auth() (without  
underscore) that calls other IMAP auth classes.

In Webdav.php (Horde_Rpc_Webdav) I have added a try / catch  
(InvalidArgumentException $e) block around the return  
$this->check_auth($auth_type, $auth_user, $auth_pw);
in else if (method_exists($this, "check_auth")) statement
that returns false in the catch block

Then the Auth Basic header is sent at first request and then Basic  
Auth is asked to the client and it works again.

If you need this on a patch format feel free to ask me (since I don't  
know if it breaks other things)

What I find strange is that the _check_auth func checks for a  
check_auth method in the same class, always returning true...