[Tickets #10326] Re: even more Ulaform refactoring for H4

bugs at horde.org bugs at horde.org
Tue Jul 12 11:05:12 UTC 2011


DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10326
------------------------------------------------------------------------------
  Ticket             | 10326
  Updated By         | vilius at lnk.lt
  Summary            | even more Ulaform refactoring for H4
  Queue              | Ulaform
  Type               | Enhancement
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Jan Schneider
------------------------------------------------------------------------------


vilius at lnk.lt (2011-07-12 11:05) wrote:

> - I've seen a few cases where you handle legacy lowercase action  
> names. How about adding a migration instead to ucfirst the actions  
> in the forms table once and for all?

When I  started refactoring I thought that legacy action handling must  
be done only in one or two places and that it will be easier. But now  
I'm convinced that migration script probably would have been a better  
idea. Will prepare a patch later.

> - You can simplify redirection by using Horde::url('foo.php')->redirect()

Does adding redirect() automatically assumes that URL is full and I  
don't need second parameter? Or do I still need Horde::url('foo.php',  
true)->redirect() ?






More information about the bugs mailing list