[Tickets #10455] Cannot disable available filter rules using Sieve

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10455
------------------------------------------------------------------------------
  Ticket             | 10455
  Created By         | jmDS at hampshire.edu
  Summary            | Cannot disable available filter rules using Sieve
  Queue              | Ingo
  Version            | 2.0.4
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


jmDS at hampshire.edu (2011-08-24 19:38) wrote:

I'm attempting to disable/remove all of the rules available by default  
in Ingo. In prefs.php, there are five preferences (one for each of  
whitelist, blacklist, forward, vacation, spam). Locking these is  
supposed to disable them and remove them from the filter list for the  
user.

However, locking all five preferences only removes 'whitelist' and  
'blacklist' from the filter list in Ingo. I believe that the reason  
for this is as follows:

This functionality is provided in lib/Ingo.php on lines 70-85. It  
creates an array called $categories. Then, for each of the five  
preferences above, it attempts to remove that option from the  
categories array. I believe the problem is that it's unsetting the  
element in the array whose position is, for example,  
Ingo_Storage::ACTION_BLACKLIST instead of the element in the array  
whose value is Ingo_Storage::ACTION_BLACKLIST.

On my Horde server, I replaced that code with the patch I've included,  
which produces the functionality I expect.