[Tickets #9767] Re: Login tasks don't work

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/9767
------------------------------------------------------------------------------
  Ticket             | 9767
  Updated By         | rsalmon at mbpgroup.com
  Summary            | Login tasks don't work
  Queue              | Horde Base
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 3. High
  Milestone          |
  Patch              |
  Owners             | Horde Developers, Jan Schneider
------------------------------------------------------------------------------


rsalmon at mbpgroup.com (2011-10-06 10:25) wrote:

> Someone will have to figure out where this chain is broken.

with the following patch, I get logintasks running and pref  
last_logintasks looks better :

a:3:{s:5:"_once";a:7:{i:0;s:45:"turba_LoginTasks_SystemTask_UpgradeFromTurba2";i:1;s:40:"turba_LoginTasks_SystemTask_UpgradePrefs";i:2;s:40:"turba_LoginTasks_SystemTask_UpgradeLists";i:3;s:45:"horde_LoginTasks_SystemTask_UpgradeFromHorde3";i:4;s:41:"imp_LoginTasks_SystemTask_UpgradeFromImp4";i:5;s:45:"imp_LoginTasks_SystemTask_UpgradeFromImp4Auth";i:6;s:43:"ingo_LoginTasks_SystemTask_UpgradeFromIngo1";}s:5:"horde";i:1317895501;s:3:"imp";i:1317895608;}


---  
../../../../git/horde/framework/LoginTasks/lib/Horde/LoginTasks/Tasklist.php	2011-09-12 08:51:58.000000000  
+0200
+++ Tasklist.php	2011-10-06 12:09:49.000000000 +0200
@@ -131,7 +131,7 @@
          while (list(, $v) = each($this->_tasks)) {
              if (!$v->needsDisplay() ||
                  (!is_null($previous) && !$v->joinDisplayWith($previous))) {
-                break;
+                continue;
              }
              $tmp[] = $v;
              $previous = $v;