[Tickets #10766] fb.php

[bugs at horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/10766
------------------------------------------------------------------------------
  Ticket           | 10766
  Erstellt Von     | michael.groene at zel.uni-hannover.de
  Zusammenfassung  | fb.php
  Warteschlange    | Kronolith
  Version          | 3.0.11
  Typ              | Bug
  Status           | Unconfirmed
  Priorität        | 1. Low
  Milestone        |
  Patch            |
  Zuständige       |
------------------------------------------------------------------------------


michael.groene at zel.uni-hannover.de (2011-11-15 13:32) hat geschrieben:

Just stumbled on these lines in kronolith/fb.php:45

         // If the free/busy calendars preference is empty, default to
         // the user's default_share preference, and if that's empty,
         // to their username.
         if (!$cal) {
             $cal = 'internal_' . $prefs->getValue('default_share');
             if (!$cal) {
                 $cal = 'internal_' . $user;
             }
         }

Am I wrong, or will the innermost if-condition never be true?  
"internal_" will be stored in every case, which makes the next if  
redundant!?