[Tickets #10804] Re: some issues with the new weather block

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10804
------------------------------------------------------------------------------
  Ticket             | 10804
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | some issues with the new weather block
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2011-11-28 12:11) wrote:

The problem is that the weather object is a singleton, and at least  
the google driver fetches all information at one.
This is a problem if you have a calendar block including weather  
information from timeobjects before the weather block. The timeobjects  
driver is trying to guess the location, and set the requested unit  
based on the current location. But to find a valid location, it  
requests data from Google, instantiating the singleton weather object,  
getting the weather data together with the location data, and no  
longer requesting the (now cached) weather data when this is needed.  
So it doesn't help resetting the unit property after instantiating the  
weather object.
The solution could be to do the unit conversions on-demand, i.e. only  
when actually calling getCurrentConditions() etc. getForecast() even  
allows to pass the units (getCurrentConditions() doesn't), but it's  
not used.