[Tickets #10829] Re: Add missing units current wind condition

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10829
------------------------------------------------------------------------------
  Ticket             | 10829
  Updated By         | arjen+horde at de-korte.org
  Summary            | Add missing units current wind condition
  Queue              | Horde Base
  Version            | Git master
  Type               | Bug
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


arjen+horde at de-korte.org (2011-12-09 16:08) wrote:

> Added the missing units, and the additional space, but I didn't  
> break out the sprintf() strings into pure concatenation as your  
> patch did. Not sure why you wanted it that way.

I understood from the earlier comments of Jan that this was a better  
way of dealing with gettext strings. Keep them as simple as possible,  
so that a change in formatting or otherwise similar uses get  
translated without additional effort. Apparently, I misunderstood his  
comments.

> Also, the patch that accompanies the "add missing semicolon" comment  
> doesn't appear to do anything different than the first patch - and  
> doesn't add any semicolon...

If you look more closely, you'll see that the semicolon in the '°'  
was missing, which I added later on. I didn't make a difference in  
output.