[Tickets #10857] Wunderground doesn't use client IP when searching by IP

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10857
------------------------------------------------------------------------------
  Ticket             | 10857
  Created By         | arjen+horde at de-korte.org
  Summary            | Wunderground doesn't use client IP when searching by IP
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


arjen+horde at de-korte.org (2011-12-12 19:32) wrote:

When searching for the location by IP, the WeatherUnderground driver  
omits passing the client IP that is passed in _getLocationByIp.  
Although this is valid (in terms of the Wunderground API), this will  
cause the lookup to be based on the server IP, which might not be  
where the client is located. The attached patch fixes this.

Another thing that pops up after applying this patch, is that the  
driver will happily attempt to do geolookups for IP addresses from  
reserved (RFC1918) or ZeroConf (RFC3330) address space that are known  
to fail. Although this will be dealt with cleanly by Wunderground, we  
could save the cost of looking this up by checking this beforehand  
(through Net/CheckIP2 or someting similar). But this would probably  
need to be done in timeobjects/lib/Driver/Weather.php, where this  
might be handled for all drivers.



arjen+horde at de-korte.org (2011-12-12 19:32) uploaded: Service_Weather.diff

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=Service_Weather.diff&ticket=10857&fn=%2FService_Weather.diff