[Tickets #10857] Re: Wunderground doesn't use client IP when searching by IP

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10857
------------------------------------------------------------------------------
  Ticket             | 10857
  Updated By         | arjen+horde at de-korte.org
  Summary            | Wunderground doesn't use client IP when searching by IP
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
+New Attachment     | WeatherUnderground.diff
------------------------------------------------------------------------------


arjen+horde at de-korte.org (2011-12-13 19:43) wrote:

The attached patch will check the IP address that is passed in  
_getLocationByIp. If the address is found to be local, use the server  
IP address to determine the location, otherwise use the client IP  
address. Most of the time, client and server will be at the same  
location when the connection does is local. This is not perfect, but  
it is the best we can do.

For me the geolookup based on client/server IP is not very useful by  
the way. If a result is found, many times the location is so far off,  
that it is not useable anyway (in The Netherlands, many lookups result  
in a location near the AMS-IX, which is *way* off in many parts of the  
country).

I wouldn't be too heartbroken if the WeatherUnderground driver  
wouldn't use this at all, the locations are too far off to be useful  
here.



arjen+horde at de-korte.org (2011-12-13 19:43) uploaded: WeatherUnderground.diff

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=WeatherUnderground.diff&ticket=10857&fn=%2FWeatherUnderground.diff