[Tickets #10912] Re: Funambol/Android don't receive homePhone and workPhone

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/10912
------------------------------------------------------------------------------
  Ticket             | 10912
  Updated By         | rene.van.den.braken at gmail.com
  Summary            | Funambol/Android don't receive homePhone and workPhone
  Queue              | Turba
  Version            | Git master
  Type               | Bug
  State              | Feedback
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             | Jan Schneider
------------------------------------------------------------------------------


rene.van.den.braken at gmail.com (2012-02-02 15:01) wrote:

>> Unfortunatly this fix is not working.
>> I believe the function _hasValEnum is wrong.
>> It is checking keys instead of values.
> That's exactly what is necessary, and what broke with my earlier  
> attempt where we checked values instead of keys.

Sorry, but I still beleive its wrong.
if for instance
$fields['TEL']->Params['TYPE']->ValEnum['VOICE,WORK']
is set (as it is in the funambol case)
the function
_hasValEnum($fields['TEL']->Params['TYPE']->ValEnum, 'HOME')
is not true as I believe was the intention.
The explode will give
array[1]=VOICE
array[2]=HOME
and array_key_exists('HOME') from this array is not true !
it should be "array_value_exist", but that probably doesn't exist :-(

Greetings Rene.
Of course I could be wrong, but without my fix I got only one standaard email,
no other emails, phones, addresses etc.
With my "dirty" fix all fields are transfered to the phone.