[Tickets #11045] Re: Listshares cache is not beeing used when previous result is an empty array

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11045
------------------------------------------------------------------------------
  Ticket             | 11045
  Updated By         | goncalo.queiros at portugalmail.net
  Summary            | Listshares cache is not beeing used when previous
                     | result is an empty array
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Resolved
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             | Michael Rubinsky
------------------------------------------------------------------------------


goncalo.queiros at portugalmail.net (2012-03-14 14:58) wrote:

List shares is now caching a false value if $sharelist is empty.
$this->_listcache[$key] = empty($sharelist) ? false : $sharelist;

The problem is that on the first run the method will return false, but  
on the second run, because of:
return is_array($this->_listcache[$key]) ? $this->_listcache[$key] : array();

it will return an empty array.
Shouldn't it always return an empty array?