[Tickets #11082] Re: avoiding lots of empty ldap connections

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11082
------------------------------------------------------------------------------
  Ticket             | 11082
  Updated By         | dom.lalot at gmail.com
  Summary            | avoiding lots of empty ldap connections
  Queue              | Turba
  Version            | Git master
  Type               | Enhancement
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
+New Attachment     | PatchTurba.txt
------------------------------------------------------------------------------


dom.lalot at gmail.com (2012-03-20 07:55) wrote:

> Looks good, but please update your patch to:
> - follow coding standards (indention, whitespace, curly braces)
> - make the method protected and call it _connect()
> - check if $this->_ds is set *inside* _connect()

Sure, it make sense
OK, I'm not a specialist of PHP, PERL is my language, so I apologize  
for my poor PHP coding.
So my second patch is following



dom.lalot at gmail.com (2012-03-20 07:55) uploaded: PatchTurba.txt

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=PatchTurba.txt&ticket=11082&fn=%2FPatchTurba.txt