[Tickets #11071] Re: Splitting long content into multiple messages

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11071
------------------------------------------------------------------------------
  Ticket             | 11071
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | Splitting long content into multiple messages
  Queue              | Synchronization
  Version            | Git master
  Type               | Enhancement
-State              | New
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2012-03-20 11:54) wrote:

Very nice work! Just a few minor suggestions:
- Why do you add RESPONSE_SIZE_REQUIRED and replace  
RESPONSE_INVALID_CREDENTIALS with it? It's not even used.
- You could optimize the whitespace stripping. You don't need a loop  
there, a preg_match('/(\s*)$/') should be sufficient.
- Since you do the size-exceeding twice and the chunk splitting even  
thrice, you should implement this in a single helper method. At least  
the larger if-then-else blocks.
- I'm trying to understand why the "if ($state->maxObjSize <  
$clientContentLength)" cases exists. Isn't the whole purpose to split  
up objects (not only messages) that exceed the client's maximum size?  
Or is this the maximum size of the individual object on the client  
side storage (opposed to the maximum size allowed during the  
transfer)? If the latter, isn't the comparison with  
$clientContentLength incorrect because it contains more than the  
individual object?