[Tickets #11082] Re: avoiding lots of empty ldap connections

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11082
------------------------------------------------------------------------------
  Ticket             | 11082
  Updated By         | dom.lalot at gmail.com
  Summary            | avoiding lots of empty ldap connections
  Queue              | Turba
  Version            | Git master
  Type               | Enhancement
  State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
+New Attachment     | PatchTurba.txt
------------------------------------------------------------------------------


dom.lalot at gmail.com (2012-03-21 10:32) wrote:

>> OK. I have no idea to get the very last version of Ldap.php throught
>> git. Can I do that with an http access?
>
> https://raw.github.com/horde/horde/master/turba/lib/Driver/Ldap.php
>
>> I should have work directly on Ldap.php at first and may be modified
>> the original..
>>
>>
>>> Almost there. :)
>>> - Your patch removes a line that doesn't exist in the original file,
>>> please make sure to make the patch against the last release or Git
>>> version
>>> - The $this->_ds==null check should be *inside* _connect() to avoid
>>> redundency, and you need spaces before and after the operator
>>
>> OK
>>
>

Hope this is OK now!




dom.lalot at gmail.com (2012-03-21 10:32) uploaded: PatchTurba[1].txt

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=PatchTurba%5B1%5D.txt&ticket=11082&fn=%2FPatchTurba%255B1%255D.txt