[Tickets #11207] Re: Imp no longer blocking images in html emails

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11207
------------------------------------------------------------------------------
  Ticket             | 11207
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Imp no longer blocking images in html emails
  Queue              | IMP
  Version            | 5.0.21
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
-Owners             |
+Owners             | Jan Schneider
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2012-06-04 17:08) wrote:

There is nothing wrong with the preferences.  And I have verified  
multiple times that nothing has changed in IMP 5 relating to the image  
viewing code.

On my system, however, something appears broken with the Turba  
getField API call.  It matches ALL entries in the favourites table,  
even if those emails do not match the search query (the matches are  
not even close).  The query being run is this:

Array
(
     [AND] => Array
         (
             [0] => Array
                 (
                     [field] => email
                     [op] => =
                     [test] => foo at example.com
                 )
         )
)

Two problems with this query:
1) The code in the Favourites driver does not handle the '=' op, only  
the LIKE op.
2) Any AND query that doesn't match will be considered as "found" and  
will be returned. (That's why the absence of the '=' op constititues  
matching).

Thus any email address, if querying the favourites addressbook, will  
ALWAYS be considered matched AFAICT.  No idea if this is your issue  
and, if so, why it suddenly started when upgrading only IMP.