[Tickets #11478] Virtual Trash Broken

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11478
------------------------------------------------------------------------------
  Ticket             | 11478
  Created By         | tonyb at go-concepts.com
  Summary            | Virtual Trash Broken
  Queue              | IMP
  Version            | 5.0.23
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


tonyb at go-concepts.com (2012-10-08 19:54) wrote:

Virtual trash appears to be broken in IMP v5 (and in master branch  
from github).

There are two main issues I have discovered:
1 - With vtrash enabled messages were being purged immediately via  
IMAP instead of being marked as deleted
2 - Once issue 1 was resolved messages were marked as deleted but they  
were being shown in their original folder and the Virtual trash was  
empty.

There is a typo in imp/lib/Mailbox.php causing issue #2 and I think  
there is a logic error in imp/lib/Message.php causing the first issue.

Attached is a patch against 5.0.23 (also available here:  
https://gist.github.com/3835398) and I will submit a pull request  
against master at github.



tonyb at go-concepts.com (2012-10-08 19:54) uploaded: imp-vtrash.patch

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=imp-vtrash.patch&ticket=11478&fn=%2Fimp-vtrash.patch