[Tickets #11305] Re: Kolab storage: Move of objects does not update the cache

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11305
------------------------------------------------------------------------------
  Ticket             | 11305
  Updated By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | Kolab storage: Move of objects does not update the
                     | cache
  Queue              | Horde Framework Packages
  Version            | Git develop
  Type               | Bug
  State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             | Gunnar Wrobel
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2012-11-07 08:55) wrote:

> commit dbde575d75584f0fe2da3f67f91e13e62f30eebe
> Author: Gunnar Wrobel <p at rdus.de>
> Date:   Tue Aug 21 10:17:58 2012 +0200
>
>     Quick fix for the moving issue #11305.
>
>  .../lib/Horde/Kolab/Storage/Data/Base.php          |    8 ++++++++
>  kronolith/lib/Driver/Kolab.php                     |    7 +++----
>  mnemo/lib/Driver/Kolab.php                         |    1 +
>  nag/lib/Driver/Kolab.php                           |    3 ++-
>  4 files changed, 14 insertions(+), 5 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/dbde575d75584f0fe2da3f67f91e13e62f30eebe

I have a quick question regarding this code change:

The added code in move() looks like this:
--------------------------------------
...
         $this->synchronize(
             array(
                 'changes' => array(
                     Horde_Kolab_Storage_Folder_Stamp::ADDED => array(),
                     Horde_Kolab_Storage_Folder_Stamp::DELETED =>  
array($object_id)
                 )
             )
         );
--------------------------------------

Shouldn't it be "Horde_Kolab_Storage_Folder_Stamp::DELETED => array($uid)"?

That's the way the "delete" code a few lines below works.
Still everything seems to work fine, I'm just asking.