[Tickets #11639] Re: ActiveSync :: Extend the Autodiscover feature to return also valid answers to MS Outlook queries

[bugs at horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/11639
------------------------------------------------------------------------------
  Ticket           | 11639
  Aktualisiert Von | torben at dannhauer.info
  Zusammenfassung  | ActiveSync :: Extend the Autodiscover feature to return
                   | also valid answers to MS Outlook queries
  Warteschlange    | Horde Framework Packages
  Version          | Git develop
  Typ              | Enhancement
  Status           | Feedback
  Priorität        | 1. Low
  Milestone        |
  Patch            | 1
  Zuständige       | Michael Rubinsky
------------------------------------------------------------------------------


torben at dannhauer.info (2012-11-15 15:38) hat geschrieben:

> How about now?
>
>
> http://lists.horde.org/archives/commits/2012-November/017210.html
>
> http://lists.horde.org/archives/commits/2012-November/017212.html

Hi,
The respond schema is now detected correctly for both, Outlook and RCA.


Regarding teh logic fix: Maybe I'm missing the point, but for me it  
does make still no sense.

My observation was, that outlook 2013 performs two independet  
autodiscover steps: It tries to discover a mobilesync setting, and it  
tries to discover a conventional Outlook setting as Outlook 2010 and  
Outlook 2007 do.

Some suggestions for Autodiscover.php:
- Line  113 and 136 check both for empty repsonse schema. this could  
be done directly after entering the _buildResponseString(..)  function  
to make the rest of the function easier to read.
- Line 135 opens a conditionalblock for the "autodiscover/outlook"  
schema, so within this block, it does not make sense to check for a  
mobilesync schema as done in lines 140:144. -> what was the intention  
of the line? In my opinion we must drop that lines, because the  
comparison in line 140 is always true and thus the function returns a  
failure response.

Bye the way:
the failure response has always  the response schema for a mobilesync,  
so RCA seems not to unterstand that an error occured. the  
_buildFailureResponse(..) function should use the correct response  
schema in line 216 to allow Outlook & RCA to unterstand that the error  
code is the response to teir query.

Torben