[Tickets #11683] Re: Core/Topbar creates Prefs object twice

[bugs at horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/11683
------------------------------------------------------------------------------
  Ticket           | 11683
  Aktualisiert Von | heinz at htl-steyr.ac.at
  Zusammenfassung  | Core/Topbar creates Prefs object twice
  Warteschlange    | Horde Framework Packages
  Version          | Git master
  Typ              | Bug
  Status           | Feedback
  Priorität        | 2. Medium
  Milestone        |
  Patch            |
  Zuständige       |
------------------------------------------------------------------------------


heinz at htl-steyr.ac.at (2012-11-26 18:29) hat geschrieben:

First it makes no sense to create two (different) prefs objects in one session
  - one stored in the registry
  - one created temporary in Horde_Core_Topbar::getTree()

Secondly:
If the creation of the temporay prefs object fails a notification is set up:
The preferences backend is currently unavailable and your preferences  
have not been loaded. You may continue to use the system with default  
preferences.

This isn't  true because the "registry prefs object" works fine and i  
continue with the settings of this prefs object

Thirdly:
If Horde_Core_Factory_Prefs::_notifyError() is called in case of an  
error, errors of the
other prefs object are never logged or displayed because:
$GLOBALS['session']->set('horde', 'no_prefs', true);
To be consistent, each prefs object should have it's own 'no_prefs'  
marker, not the session.

Conclusion:
One session - one preferences object