[Tickets #11785] Re: RTL bugs in horde

[bugs at horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11785
------------------------------------------------------------------------------
  Ticket             | 11785
  Updated By         | Jan Schneider <jan at horde.org>
  Summary            | RTL bugs in horde
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
-State              | Unconfirmed
+State              | Feedback
  Priority           | 1. Low
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


Jan Schneider <jan at horde.org> (2012-11-30 16:31) wrote:

> When viewing horde in RTL mode (hebrew/arabic) the layout breaks  
> terribly, I jave started identifying some problems but since I am  
> not familiar with the framework I don't necisarrily know how to  
> solve them.
>
> One problem is some inline stile that assumes LTR languages:
> # grep -R 'style="left:' /usr/share/horde4/
> /usr/share/horde4/templates/sidebar/sidebar.html.php:<div  
> id="horde-slideleft" class="horde-splitbar-vert" style="left:<?php  
> echo $this->width ?>px">
> /usr/share/horde4/kronolith/templates/dynamic/index.inc:<div  
> id="horde-page" style="left:<?php echo  
> $prefs->getValue('sidebar_width') ?>px">

Fixed, though this doesn't change the layout of course. There's much  
more to do.

> /usr/share/horde4/kronolith/templates/fbview/busyblock.html:<td><div  
> class="kronolithFBBusy" style="left:<tag:left />;width:<tag:width  
> />;"> </div></td>
> /usr/share/horde4/kronolith/templates/fbview/meetingblock.html:<td><div  
> class="kronolithFBFree" style="left:<tag:left />;width:<tag:width  
> />;"> </div></td>

I left those out, because this also requires the fb table to be  
rendered RTL. Or is it?

> In the above examples a direction check should have been done and in  
> the case of RTL they should have read:
> style="right:<?php echo $this->width ?>px"
>
> I realize some of these are part of the kronolith project and not  
> horde at large, if you so prefer I will open a seperate bug for them.
>
> In screen.css there are also several parameters that should be  
> direction dependent, I still need to sit down longer to identify  
> them all but as a start:
> #horde-page has a padding that should be direction dependent.

Fixed. RTL specific changes go to rtl.css. Please note that I already  
updated it a bit, so make sure you work against a Git version of Horde.