[Tickets #11938] Horde_Pear fails when there is a comment in dependencies of a package.xml

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11938
------------------------------------------------------------------------------
  Ticket             | 11938
  Created By         | math.parent at gmail.com
  Summary            | Horde_Pear fails when there is a comment in
                     | dependencies of a package.xml
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


math.parent at gmail.com (2013-01-06 16:51) wrote:

When running [1]:
   php components/bin/horde-components ./framework/Kolab_Filter/ deps

I got:
Fatal Error:
Unsupported dependency type "#comment"!
In  
/home/mathieu/src/github.com/horde/horde/framework/Pear/lib/Horde/Pear/Package/Dependencies.php on line  
56

This is because "framework/Kolab_Filter/package.xml" contains a  
comment in the optionnal dependencies [2].

The attached patch fixes it.


[1]: Or more exactly, from the $web_dir:
LANG=C php -d include_path="./libs:/usr/share/php:/usr/share/pear"  
components/bin/horde-components ../horde/framework/Kolab_Filter/ deps
[2]:  
https://github.com/horde/horde/blob/master/framework/Kolab_Filter/package.xml#L230



math.parent at gmail.com (2013-01-06 16:51) uploaded:  
0001-Ignore-comments-in-package.xml-as-found-in-Horde_Kol.patch

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=0001-Ignore-comments-in-package.xml-as-found-in-Horde_Kol.patch&ticket=11938&fn=%2F0001-Ignore-comments-in-package.xml-as-found-in-Horde_Kol.patch