[Tickets #11999] Prevent inserting empty share "objects" into $all_shares array

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/11999
------------------------------------------------------------------------------
  Ticket             | 11999
  Created By         | Thomas Jarosch <thomas.jarosch at intra2net.com>
  Summary            | Prevent inserting empty share "objects" into
                     | $all_shares array
  Queue              | Horde Framework Packages
  Version            | Git master
  Type               | Bug
  State              | Unconfirmed
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
  Owners             |
------------------------------------------------------------------------------


Thomas Jarosch <thomas.jarosch at intra2net.com> (2013-01-28 10:55) wrote:

Hi,

I just had a crash during login:

[Mon Jan 28 11:14:31 2013] [error] [client 127.0.0.1] PHP Fatal error:  
  Call to a member function getName() on a non-object in  
/usr/share/pear/Horde/Share/Base.php on line 716

Full backtrace:
#0 [internal function]:  
Horde_Share_Base->_sortShares(Object(Horde_Share_Object_Kolab), NULL)
#1 /usr/share/pear/Horde/Share/Base.php(356): uasort(Array, Array)
#2 [internal function]: Horde_Share_Base->listShares('USERNAME', Array)
#3 /usr/share/pear/Horde/Core/Share/Driver.php(61):  
call_user_func_array(Array, Array)
#4 /usr/share/pear/www/horde/turba/lib/Turba.php(623):  
Horde_Core_Share_Driver->__call('listShares', Array)
#5 /usr/share/pear/www/horde/turba/lib/Turba.php(623):  
Horde_Core_Share_Driver->listShares('USERNAME', Array)
#6 /usr/share/pear/www/horde/turba/lib/Turba.php(442): Turba::listShares()
#7 /usr/share/pear/www/horde/turba/lib/Application.php(87):  
Turba::getConfigFromShares(Array)
#8 /usr/share/pear/Horde/Registry/Application.php(105):  
Turba_Application->_init()
#9 [internal function]: Horde_Registry_Application->init()
#10 /usr/share/pear/Horde/Registry.php(1139):  
call_user_func_array(Array, Array)
#11 /usr/share/pear/Horde/Registry.php(1543):  
Horde_Registry->callAppMethod('turba', 'init')
#12 /usr/share/pear/Horde/Registry.php(1071):  
Horde_Registry->pushApp('turba', Array)
#13 /usr/share/pear/Horde/Registry.php(1031):  
Horde_Registry->callByPackage('turba', 'listTimeObjectC...', Array)
#14 /usr/share/pear/www/horde/kronolith/lib/Kronolith.php(912):  
Horde_Registry->call('contacts/listTi...')
#15 /usr/share/pear/www/horde/kronolith/lib/Application.php(75):  
Kronolith::initialize()
#16 /usr/share/pear/Horde/Registry/Application.php(105):  
Kronolith_Application->_init()
#17 [internal function]: Horde_Registry_Application->init()
#18 /usr/share/pear/Horde/Registry.php(1139):  
call_user_func_array(Array, Array)
#19 /usr/share/pear/Horde/Registry.php(1543):  
Horde_Registry->callAppMethod('kronolith', 'init')
#20 /usr/share/pear/Horde/Registry.php(1136):  
Horde_Registry->pushApp('kronolith', Array)
#21 /usr/share/pear/Horde/Core/Factory/Notification.php(63):  
Horde_Registry->callAppMethod('kronolith', 'setupNotificati...', Array)
#22 /usr/share/pear/Horde/Injector/Binder/Factory.php(111):  
Horde_Core_Factory_Notification->create(Object(Horde_Injector))
#23 /usr/share/pear/Horde/Injector.php(213):  
Horde_Injector_Binder_Factory->create(Object(Horde_Injector))
#24 /usr/share/pear/Horde/Injector.php(247):  
Horde_Injector->createInstance('Horde_Notificat...')
#25 /usr/share/pear/Horde/Registry.php(507):  
Horde_Injector->getInstance('Horde_Notificat...')
#26 /usr/share/pear/Horde/Registry.php(238):  
Horde_Registry->__construct(0, Array)
#27 /usr/share/pear/www/horde/index.php(20):  
Horde_Registry::appInit('horde', Array)
#28 {main}


Turned out we added empty "objects" to the $all_shares list.
Attached patch fixes that.

Thomas