[Tickets #11983] Re: limit synced mailboxes by user preferences

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/11983
------------------------------------------------------------------------------
  Ticket           | 11983
  Aktualisiert Von | jmozdzen at nde.ag
  Zusammenfassung  | limit synced mailboxes by user preferences
  Warteschlange    | Synchronization
  Version          | Git master
  Typ              | Enhancement
  Status           | Feedback
  Priorität        | 1. Low
  Milestone        | 5,1
  Patch            | 1
  Zuständige       |
+Neue Anlage      | Driver.php.diff
------------------------------------------------------------------------------


jmozdzen at nde.ag (2013-02-04 17:47) hat geschrieben:

>>> Feel free to submit a patch and I'll review.
>>
>> So here's my attempt to a patch to
>> /usr/share/php5/PEAR/Horde/Core/ActiveSync/Driver.php
>
> 1) You need to review http://www.horde.org/apps/horde/docs/CODING_STANDARDS
> 2) _getMailFolder() still calls getSpecialMailboxes() and compares  
> the names anyway. You should build the map of the special mailboxes  
> regardless if it is $inbox_only or not, store it locally in the  
> object and use it in getMailFolder() as well.

I've tried to incorporate your comments - is this new patch sufficient  
for approval?

Concerning the array of special mailboxes - is my approach  
(initializing the member to "null" in the c'tor and verifying against  
that value for lazy loading in "_getMailFolders()") correct?

Let me know if I should further improve this patch.



jmozdzen at nde.ag (2013-02-04 17:47) hat hochgeladen: Driver.php.diff

http://bugs.horde.org/h/services/download/?module=whups&actionID=download_file&file=Driver.php.diff&ticket=11983&fn=%2FDriver.php.diff