[Tickets #12081] badlogin not working whith IMP authentication

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12081
------------------------------------------------------------------------------
  Ticket             | 12081
  Created By         | patrick.vangilst at labri.fr
  Summary            | badlogin not working whith IMP authentication
  Queue              | Horde Groupware Webmail Edition
  Version            | 5.0.4
  Type               | Bug
  State              | Unconfirmed
  Priority           | 2. Medium
  Milestone          |
  Patch              |
  Owners             |
------------------------------------------------------------------------------


patrick.vangilst at labri.fr (2013-03-01 13:30) wrote:

It seems that the function _badLogin($userId) (in Auth/Base.php) is  
never used with IMP authentication.
What I understand is that this function is called when en exception  
Horde_Auth::REASON_BADLOGIN is thrown. This is the code in  
Auth/Base.php:

    } catch (Horde_Auth_Exception $e) {
             if (($code = $e->getCode()) &&
                 $code != Horde_Auth::REASON_MESSAGE) {
                 if (($code == Horde_Auth::REASON_BADLOGIN) &&
                     $this->hasCapability('badlogincount')) {
                     $this->_badLogin($userId);
                 }
                 $this->setError($code, $e->getMessage());
             } else {
                 $this->setError(Horde_Auth::REASON_MESSAGE, $e->getMessage());
             }
             return false;
         }

Unfortunately, this never occurs with IMP authentication. I think some  
code is missing, in case of wrong login/password, something like:

throw new Horde_Auth_Exception('', Horde_Auth::REASON_BADLOGIN);

But I don't know where.....