[Tickets #11738] Re: Revamped kolab-webmail bundle for H5

[noreply at bugs.horde.org]

BITTE NICHT AUF DIESE NACHRICHT ANTWORTEN. NACHRICHTEN AN DIESE  
E-MAIL-ADRESSE WERDEN NICHT GELESEN.

Ticket-URL: http://bugs.horde.org/ticket/11738
------------------------------------------------------------------------------
  Ticket           | 11738
  Aktualisiert Von | jmozdzen at nde.ag
  Zusammenfassung  | Revamped kolab-webmail bundle for H5
  Warteschlange    | Kolab
  Typ              | Enhancement
  Status           | Feedback
  Priorität        | 2. Medium
  Milestone        |
  Patch            |
  Zuständige       |
------------------------------------------------------------------------------


jmozdzen at nde.ag (2013-03-01 21:36) hat geschrieben:

> There's still a few of my questions unanswered/unresolved.

Thanks for pointing this out - from my point of view I had already  
declared the basar closed ;)

> - Why does  
> $GLOBALS['injector']->getInstance('Horde_Kolab_Session')->getImapServer()  
> not work?
As I wrote, I couldn't tell. I just observed that it does work with an  
explicitly set server and doesn't via the injector statement. But upon  
re-reading this ticket, I noticed that now, due to some other change,  
a re-check is in order - yes, the injector statements currently work.
BTW, what advantage is it in IMP to read the hostname via injector,  
but read the port number from the config? I suggest you or anyone more  
Horde-experienced than me to look this over and create a probably more  
consistent usage of the pre-configured IMAP server.

Do you need a modified patch?

> - Why did you remove the mbox_icon and display_folder hooks?
Do you see this as unresolved? I have not received any response to my  
comments and was not able to resolve the issue myself.
I just retested, when activating the mbox_icon hook the folder list on  
the left no longer loads in IMP, but despite DEBUG logging I couldn't  
spot obvious error messages. It's sufficient to have the code in  
hooks.php, even when not activated in imp/conf.d.

> - Why are the $vars->ldap__* setters necessary?
Do you see this as unresolved? I have not received any response to my  
comments and concluded from my tests that those values needed to be  
set to make it work. Thus I had set them.

Please let me know what you see as open points where I can help.