[Tickets #12097] Re: Export of mailfolders fails with cyrus imap

[noreply at bugs.horde.org]

DO NOT REPLY TO THIS MESSAGE. THIS EMAIL ADDRESS IS NOT MONITORED.

Ticket URL: http://bugs.horde.org/ticket/12097
------------------------------------------------------------------------------
  Ticket             | 12097
  Updated By         | Michael Slusarz <slusarz at horde.org>
  Summary            | Export of mailfolders fails with cyrus imap
  Queue              | Horde Groupware Webmail Edition
  Version            | 5.0.4
  Type               | Bug
-State              | Feedback
+State              | Assigned
  Priority           | 1. Low
  Milestone          |
  Patch              | 1
-Owners             |
+Owners             | Michael Slusarz
------------------------------------------------------------------------------


Michael Slusarz <slusarz at horde.org> (2013-03-07 13:58) wrote:

See also (possibly) Ticket #12031

> You may say: This is also not solving the origin problem but  I  
> think as long as you cannot be sure the method returns integer  
> values in all cases you have to check the result in calling processes.

I disagree.

For a general purpose API call that is exposed to any users (in other  
words, where you don't control the calling code) it may make sense to  
be super liberal in what you accept.

But for a specific API/function call that really is only meant to be  
called within the library, this is a bad idea because:

1) You control the input and should guarantee the data is correct here
2) Because if you cant guarantee #1, that means there is a bug in our  
code that needs to be fixed (and may be causing issues elsewhere)
3) You are just adding complexity and performance hits when not necessary